[EM-193] - Update displayed error message when payment failed #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpariwat
approved these changes
Mar 22, 2021
jacstn
approved these changes
Mar 22, 2021
tookaa2
approved these changes
Mar 22, 2021
rezigned
approved these changes
Mar 22, 2021
danfowler
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Explain in non-technical terms WHY this PR is required.
E.g.: What feature it adds, what problem it solves...
This section will be used in the release notes.
Error mappings are introduced to update the error message on the plugin. This will give a more detailed error message to the consumer than what is provided by the API.
Related information:
Related issue(s): #< GitHub ticket number > (optional)
2. Description of change
A general description of WHAT changed in the codebase, but short of an English version of the diff. Assume that people reading this will also be looking at the output of
git diffand guide them to the highlights.Additionally add the reasoning for change details if they're complex or abstract.
Modified the translations for 'failed processing' and 'payment rejected' messages to the message provided from the customer support team.
3. Quality assurance
Specify where and how you tested this and what further testing it might need.
Added unit tests for the translations on PHPUnit. Did manual testing and the result is as expected.
🔧 Environments:
Specify the details of your test environments, including, for each, the platform version (on which the plugin was run), the Omise plugin version, and the versions of your system software such as PHP or Ruby.
i.e.
✏️ Details:
Explain how to manually test this feature.
For example if changes were made in the UI or in the API, explain where and if any specific access is needed.
Use the test mode and create charge using these failure cards https://www.omise.co/api-testing to see the expected output.
4. Impact of the change
List the steps that must be taken for this PR to work.
E.g.: rake yak:shave, Add "yak_key" to environment variables, ...
Be sure to include all systems that needs to be changed or which system is affected by the change
(Ex: Requires Elastic search to be installed and configured in secrets.yml).
None
Note: Please provide a screenshot if your changed impact to UI.
Error messages changed in the output.
5. Priority of change
Normal, High or Immediate.
High
6. Additional Notes
Any further information that you would like to add.