Auto formatting card numbers in input field on checkout page and My account page. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkathale
requested review from
danfowler,
tiponche,
tommy-omise and
pariyathida
danfowler
reviewed
Dec 1, 2020
danfowler
approved these changes
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
This PR auto-formats the input number in card field at checkout field.
For example:
if user inputs,
411111 which converts to
4111 114111111111 which converts to
4111 1111 114111111111111 which converts to
4111 1111 1111 1This changes has done in 'Save Card' section in My account page and Checkout page.
Save Card page:
Checkout page:
Related information:
Related issue(s): https://omise.atlassian.net/browse/FES-211
2. Description of change
Updated Javascript files which reformats to input value of input field which also takes of spaces from input values before sending to omise api. modified files are assets/javascripts/omise-myaccount-card-handler.js , assets/javascripts/omise-payment-form-handler.js
Added javascript on the form template : templates/payment/form-creditcard.php
3. Quality assurance
🔧 Environments:
i.e.
✏️ Details:
Steps for testing:
4. Impact of the change
Card payment method should work normally.
5. Priority of change
Normal
6. Additional Notes
NA