Refresh QR payment screen once customer completes payment #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkathale
requested review from
danfowler,
tiponche,
tommy-omise and
pariyathida
danfowler
approved these changes
Nov 30, 2020
| @@ -93,7 +93,72 @@ public function display_qrcode( $order, $context = 'view' ) { | |||
| <div class="omise omise-paynow-qrcode"> | |||
| <img src="<?php echo $qrcode; ?>" alt="Omise QR code ID: <?php echo $charge['source']['scannable_code']['image']['id']; ?>"> | |||
| </div> | |||
| <div class="omise-paynow-payment-status"> | |||
| <div class="pending"> | |||
| <?php echo __( 'Waiting for payment. Session on this window for payment would timeout in <span id="timer">10:00</span> minutes.', 'omise' ); ?> | |||
There was a problem hiding this comment.
How about "Payment session will time out in..."?
Co-authored-by: Daniel Fowler <[email protected]>
Co-authored-by: Daniel Fowler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
This PR is to removes QR code from order success page and show actual status of payment in real time, once customer scans the QR code and make the payment. Timeout of 10 minutes has been added on the order success page to keep checking status of charge.
Payment Pending screen:
Payment complete screen:
Payment timeout screen:
Related information:
Related issue(s): https://omise.atlassian.net/browse/FES-207
2. Description of change
includes/gateway/class-omise-payment-paynow.phptemplate page by adding javascript code which sends xhr request to rest api.includes/class-omise-rest-webhooks-controller.phpto add new rest api controller.3. Quality assurance
🔧 Environments:
i.e.
✏️ Details:
4. Impact of the change
Order success page should be modified after this PR. It should show actual payment status.
5. Priority of change
Normal
6. Additional Notes
None