Rendering barcode in mobile phones vertically to avoid breakline. #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkathale
requested review from
danfowler,
tiponche,
tommy-omise and
pariyathida
mayurkathale
changed the title
danfowler
approved these changes
Nov 30, 2020
tommy-omise
approved these changes
Nov 30, 2020
pariyathida
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
This PR is to fix issue for display of Tesco Lotus barcode on Order success page. Whenever barcode width is longer than width of screen, it breaks into 2 lines which is not readable by Barcode scanner. To overcome this issue, displaying barcode in mobile phones vertically. Keeping desktop version same.
Related information:
Related issue(s): https://omise.atlassian.net/browse/FES-228
2. Description of change
3. Quality assurance
🔧 Environments:
i.e.
✏️ Details:
Try to checkout using tesco lotus barcode payment. See the result on the order success page.
4. Impact of the change
Barcode shouldn't break into 2 lines.
5. Priority of change
Normal
6. Additional Notes
NA