Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move usage docs to website #172

Merged
merged 1 commit into from
Jun 26, 2020
Merged

Move usage docs to website #172

merged 1 commit into from
Jun 26, 2020

Conversation

danfowler
Copy link
Contributor

1. Objective

Usage docs are at https://www.omise.co/woocommerce-plugin

2. Description of change

Just the README

3. Quality assurance

n/a

4. Impact of the change

n/a

5. Priority of change

Normal

6. Additional Notes

n/a

@guzzilar
Copy link
Contributor

Would it be better to leave this Contributing section as it is? It's a different content from our Doc and more focus on guiding user where and how to submit issue and PR.
Screen Shot 2563-06-25 at 10 19 35

@danfowler
Copy link
Contributor Author

@guzzilar thanks for the feedback, but I think most of the existing content is implicit to making contributions on GitHub in general. We can start re-adding to this section once we have more specific guidelines for contributors.

Also, the license should be in a LICENSE file. I've made a separate PR to add it: #173

Copy link
Contributor

@guzzilar guzzilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think that we should keep the Contributing section although it's a general guideline, as removing doesn't give a better benefit (as far as I know) but having it can still give a general idea on how do normally opening issue & PR in GitHub work.

@danfowler danfowler merged commit 0c959d9 into master Jun 26, 2020
@danfowler danfowler deleted the dedupe-plugin-documentation branch June 26, 2020 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants