Bill Payment: adding white-background to a displayed barcode (both we… #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
To prevent a situation where Bill Payment barcode might be displayed at a website or an email client that is themed in a black background or in a dark theme.
2. Description of change
<div style="clear:both"></div>
into<div class="omise-billpayment-tesco-barcode
">...`.Before:
After:
The reason is those barcode elements are set to
float: left
and without clearing its floating position properly, we can't set a white background to.omise-billpayment-tesco-barcode
element.3. Quality assurance
✏️ Details:
Just test setting content's background to be black or using dark color then purchase an item with Bill Payment payment method while you are still at the dark-color theme.
Then, using any free barcode scanner application (mobile) to test scan barcode if it worked.
I did test scan the above barcodes on both website and email. It works properly.
4. Impact of the change
Nothing
5. Priority of change
Normal
6. Additional Notes
Suggested by @jonrandy