Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bill Payment: adding white-background to a displayed barcode (both we… #128

Merged
merged 1 commit into from
Aug 14, 2019

Conversation

guzzilar
Copy link
Contributor

@guzzilar guzzilar commented Aug 13, 2019

1. Objective

To prevent a situation where Bill Payment barcode might be displayed at a website or an email client that is themed in a black background or in a dark theme.

2. Description of change

  • Adding a white background to a barcode's parent div element.
  • Also rearrange a div element (moving <div style="clear:both"></div> into <div class="omise-billpayment-tesco-barcode">...`.

Before:

<div class="omise-billpayment-tesco-barcode">
    <div>... bar code ...</div>
    <div>... bar code ...</div>
    <div>... bar code ...</div>
</div>
<div style="clear:both"></div>

After:

<div class="omise-billpayment-tesco-barcode" style="background-color: #ffffff;">
    <div>... bar code ...</div>
    <div>... bar code ...</div>
    <div>... bar code ...</div>
    <div style="clear:both"></div>
</div>

The reason is those barcode elements are set to float: left and without clearing its floating position properly, we can't set a white background to .omise-billpayment-tesco-barcode element.

3. Quality assurance

✏️ Details:

Just test setting content's background to be black or using dark color then purchase an item with Bill Payment payment method while you are still at the dark-color theme.
Then, using any free barcode scanner application (mobile) to test scan barcode if it worked.

Screen Shot 2562-08-13 at 21 45 52

Screen Shot 2562-08-13 at 22 06 19

I did test scan the above barcodes on both website and email. It works properly.

4. Impact of the change

Nothing

5. Priority of change

Normal

6. Additional Notes

Suggested by @jonrandy

…bsite and email).

To prevent a situation where Bill Payment barcode is displayed at a website or an email where a store's theme is black or in dark theme.
@guzzilar
Copy link
Contributor Author

thanks, guys 👍

@guzzilar guzzilar merged commit e1351e5 into master Aug 14, 2019
@guzzilar guzzilar deleted the billpayment-improve-printing-barcode branch August 14, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants