Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating README.md, adding 2 missing payment methods at 'Enable payme… #127

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

guzzilar
Copy link
Contributor

@guzzilar guzzilar commented Aug 8, 2019

Updating document.

@@ -60,7 +60,7 @@ Once the installation is done, the next thing that you are going to do is to con

#### Enable payment methods

> Note that Alipay and Internet Banking payment methods are only available for merchants with a Thai-registered Omise account.
> Note that Alipay, Bill Payment: Tesco, Installment, and Internet Banking payment methods are only available for merchants with a Thai-registered Omise account.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we swap those two options were just added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean by swap?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean put the Installment in front of the Bill Payment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind this comment. I just realized how you sort this list

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

README.md Outdated
@@ -60,7 +60,7 @@ Once the installation is done, the next thing that you are going to do is to con

#### Enable payment methods

> Note that Alipay and Internet Banking payment methods are only available for merchants with a Thai-registered Omise account.
> Note that Alipay, Bill Payment: Tesco, Installment, and Internet Banking payment methods are only available for merchants with a Thai-registered Omise account.

There are 3 payment methods that you can enable on your store, which are **Alipay**, **Credit / Debit Card**, and **Internet Banking**.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add those payment methods here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let me update screenshot for this section too.

@guzzilar
Copy link
Contributor Author

guzzilar commented Aug 8, 2019

@pitiphong-p ok, done. (there are some old screenshots, I'll update again once make a new release, this one let me focus on adding missing payment methods from document)

Thanks 👍

@guzzilar
Copy link
Contributor Author

guzzilar commented Aug 8, 2019

Thanks for the review, that's pretty fast @pitiphong-p 👍

@guzzilar guzzilar merged commit 5ba6914 into master Aug 8, 2019
@guzzilar guzzilar deleted the update-readme branch August 8, 2019 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants