Repository navigation
Keep shell tests inside their fixtures - #6763
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Makes shell tests independent of the host Omarchy installation.
Changes:
- Points bar defaults at the repository checkout.
- Stubs laptop-monitor detection with the fixture’s
eDP-1display.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/shell.d/bar-test.sh |
Sets fixture-local OMARCHY_PATH. |
test/shell.d/monitor-clamshell-scale-test.sh |
Adds deterministic laptop-monitor detection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
torturado
pushed a commit
to torturado/omarchy
that referenced
this pull request
Aug 19, 2026
jnadeau207-collab
pushed a commit
to jnadeau207-collab/omarchy-7-ultimate
that referenced
this pull request
Aug 26, 2026
nick1udwig
pushed a commit
to nick1udwig/omarchy
that referenced
this pull request
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shell tests should not depend on the machine that happens to run them. These two fixtures were still borrowing state from an installed Omarchy environment.
<<< AI wording below >>>
Problem
Two shell tests only passed reliably when launched from an already configured Omarchy session:
OMARCHY_PATH, so it failed when that runtime variable was absent and could read defaults from the installed tree when it pointed elsewhereomarchy-hyprland-monitor-laptop, so it called the host detector and based its fake-monitor assertions on real hardwareThis made clean-VM runs fail while Omarchy-hosted runs could hide the fixture gaps.
Fix
Point the bar fixture at the checkout it is testing, and make the clamshell fixture return its declared fake laptop panel.
Runtime code is unchanged.
Verification
env -u OMARCHY_PATH PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin bash test/shell.d/bar-test.shenv -u OMARCHY_PATH PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin bash test/shell.d/monitor-clamshell-scale-test.shbash -n test/shell.d/bar-test.sh test/shell.d/monitor-clamshell-scale-test.shgit diff --check