Repository navigation
Treat LVDS panels as internal displays - #6752
Merged
dhh merged 2 commits intoAug 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates physical monitor detection to consistently recognize eDP, LVDS, and DSI panels as internal displays.
Changes:
- Expands internal connector detection and supports an overridable DRM path.
- Adds connector behavior tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
bin/omarchy-hw-external-monitors |
Excludes common internal panels from external monitor detection. |
test/shell.d/hw-external-monitors-test.sh |
Tests internal, external, and disconnected connectors. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nick1udwig
pushed a commit
to nick1udwig/omarchy
that referenced
this pull request
Sep 9, 2026
* Treat LVDS panels as internal displays * Test empty DRM monitor discovery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops LVDS and DSI laptop panels from being mistaken for physically connected external monitors. Closes #5906.
<<< AI wording below >>>
Problem
Quattro already recognizes
eDP,LVDS, andDSIas internal displays in its Hyprland helpers, butomarchy-hw-external-monitorsstill excludes only eDP. On an LVDS laptop, the lid-close path can therefore believe the only display is external and try to disable it.Fix
Use the same internal connector set in the physical DRM check, skip missing glob matches, and make the DRM root overridable for isolated tests.
Verification
./test/cli.