Remove Noto Sans KR and fix fallback font#225
Merged
olsh merged 1 commit intoolsh:masterfrom Oct 16, 2022
soya-daizu:font-fix
Merged
Remove Noto Sans KR and fix fallback font#225olsh merged 1 commit intoolsh:masterfrom soya-daizu:font-fix
olsh merged 1 commit intoolsh:masterfrom
soya-daizu:font-fix
Conversation
Owner
|
@soya-daizu thank you! 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per mentioned in the newer comments at #45, this PR removes the usage of Noto Sans CJK KR and fixes the fallback font to sans-serif from serif so that a more appropriate font will be chosen as a fallback. Also, the
font-weightof the title is now fixed to 700 to ensure that the fallback fonts are also bold.