Skip to content

[DataGrid] Initial Selection#5

Closed
Domino987 wants to merge 1 commit into
oliviertassinari:data-gridfrom
Domino987:data-grid
Closed

[DataGrid] Initial Selection#5
Domino987 wants to merge 1 commit into
oliviertassinari:data-gridfrom
Domino987:data-grid

Conversation

@Domino987

Copy link
Copy Markdown

Adding initial row and checkbox selection to the data-grid.

Adding initial row and checkbox selection to the data-grid
@oliviertassinari

Copy link
Copy Markdown
Owner

Note that @gabrielliwerant had plans to look into the selection feature.

@Domino987

Copy link
Copy Markdown
Author

I see, where did he say? He can of course join me for the selection.

@Domino987

Copy link
Copy Markdown
Author

@gabrielliwerant @oliviertassinari What do you think my approach? Could you review it?

@oliviertassinari

Copy link
Copy Markdown
Owner

@Domino987 Yes, I will give it a look by the end of the day :)

@oliviertassinari

Copy link
Copy Markdown
Owner

@Domino987 Hi, thanks for waiting. @dtassone will be leading the date grid effort. We will let you know once we can accept help :).

oliviertassinari added a commit that referenced this pull request Dec 13, 2020
Move picker sources into lab (#4)

Update README.md

[DatePicker] Refactor pickers tests to testing-library and mocha (#5)

[TimePicker] Migrate tests to testing library (#8)

[DateTimePicker] Migrate tests  (#9)

Fix all pickers linter errors (#10)

Fix all circular dependencies (#11)

* Fix all circular dependencies

* Enable mocha eslint rules for typescript tests

[test] The last step to a green CI (#15)

Migrate pickers docs (#12)

Downgrade to withStyles for pickers sources (#16)

Add public api exports for pickers components (#17)

Consolidate component namespace and theme augmentation  (#18)

Describe conformance for pickers sub-components (#19)

Autogenerate proptypes for typescript sources  (mui#20)

Proper build output (mui#21)

Clear migration artifacts  (mui#23)

Eslint rule for lower-case test name convention  (mui#24)

DateRangePicker  (mui#25)

yarn deduplicate

Remove GridListTile

[DateTimePicker] Fix migration unit tests

Fix types

Fix typescript types migration issues

Fix yarn lerna build (mui#33)

Fix karma tests

use window.Touch for CI karma tests

Remove more outdated diff noise (mui#34)

Replace not valid formats with valid ISO strings

Try to fix CI touch tests

Skip tests if Touch events are not supported

Fix merge conflicts

Actually type-check

Fix safari tests

Remove lowercase test name rule

The casing is up to the test author.
We're not the grammar police in tests.

Fix lint

Format

Remove overzealous eslint-disable*

Debug failing tests

Better debugging

Timezones are fun

was isoString th efix?

Let's find out what's failing and then skip it

Branch for safari

Skip DateRangePicker in browsers

review

Matt's review

Co-authored-by: Matt <[email protected]>

format

docs:i18n
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants