feat(core): add sideEffects flag and enhance useContext functionality#568
Merged
productdevbook merged 2 commits intomainfrom Nov 18, 2024
Merged
feat(core): add sideEffects flag and enhance useContext functionality#568productdevbook merged 2 commits intomainfrom
productdevbook merged 2 commits intomainfrom
Conversation
Contributor
|
Thank you for following the naming conventions! 🙏 |
teleskop150750
approved these changes
Nov 17, 2024
Contributor
Author
|
@teleskop150750 pr can you check again |
teleskop150750
approved these changes
Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
packages/coremodule to improve the handling of side effects and enhance thecreateContextfunction. The most important changes are detailed below:Handling of side effects:
packages/core/package.json: Added"sideEffects": falseto the package configuration to indicate that the module does not have side effects, which can help with tree-shaking during the build process.Enhancements to
createContextfunction:packages/core/src/hooks/createContext.ts: Modified theuseContextfunction to accept an optionalvalueparameter. This allows the function to use the provided value or fall back to the default value if none is provided. Additionally, the function now returnsnullexplicitly if the state isnull.