OKTA-526761: Add Caching support#768
Merged
arvindkrishnakumar-okta merged 22 commits intooasv3from Oct 6, 2022
Merged
Conversation
arvindkrishnakumar-okta
changed the title
arvindkrishnakumar-okta
changed the title
JayNewstrom
reviewed
Oct 6, 2022
JayNewstrom
left a comment
JayNewstrom
left a comment
There was a problem hiding this comment.
A few questions/comments:
- Was the cache framework copied from another repo?
- We should add integration tests as well, we have some unit test coverage of the new functionality, but we haven't tested a lot of the more complex logic in the mustache template.
- I don't think we should enable this by default, given that I'd expect most consumers to run multiple app server instances.
Contributor
Author
|
JayNewstrom
approved these changes
Oct 6, 2022
arvindkrishnakumar-okta
added a commit
that referenced
this pull request
Oct 26, 2022
…776) * Regenerate and rewrite for OASv3 using `openapi-generator.tech` (#737) * minor refactor * minor refactor * fix Travis build failure * added circle ci config * added jdk18 to circle ci config * minor refactor * minor refactor * minor refactor * minor refactor * removed unwanted file * updated readme and migrating guides and other refactoring * [maven-release-plugin] prepare release okta-sdk-root-10.0.0-beta * [maven-release-plugin] prepare for next development iteration * Release pr 10.0.0 beta (#747) * [maven-release-plugin] prepare release okta-sdk-root-10.0.0-beta * [maven-release-plugin] prepare for next development iteration * Update README.md * Add support for custom user profile attributes (#749) * add support for custom user profile attributes * added license header on new files * fix build failure * refactored * refactored * refactored * [OASv3] - OAuth for Okta (#753) * wip - oauth for okta * fix unit test failure * fix unit test failure * OKTA-526761: Add Caching support (#768) * add caching * OKTA-537443: Add Groups ITs (#772) added GroupsIT * OKTA-537444: Add Policy ITs (#773) * added PoliciesIT (signon) * Regen sdk with latest oasv3 spec (#774) * added PoliciesIT (signon) * updated PolicyIT * regen and refactor sdk with latest oasv3 spec * minor update * fix build * cve fix and prep for oasv3 GA release (#777) * cve fix and prep for oasv3 GA release * removed unwanted yaml file * revert jakarta annotation back to 1.3.5 * updated migration guide * updated circle ci config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s)
Description
oasv3feature branch.Category
Signoff