Merged
Conversation
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
api/src/main/java/com/okta/sdk/authc/credentials/OAuth2ClientCredentials.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 2, 2020
impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 2, 2020
impl/src/main/java/com/okta/sdk/impl/client/DefaultClientBuilder.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 2, 2020
bdemers
reviewed
Apr 27, 2020
impl/src/main/java/com/okta/sdk/impl/api/OAuth2ApiClientCredentialsResolver.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 27, 2020
impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 27, 2020
impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java
Outdated
Show resolved
Hide resolved
bdemers
reviewed
Apr 27, 2020
impl/src/main/java/com/okta/sdk/impl/oauth2/OAuth2ClientCredentials.java
Show resolved
Hide resolved
bdemers
reviewed
Apr 27, 2020
bdemers
reviewed
Apr 27, 2020
bdemers
approved these changes
Apr 27, 2020
Contributor
bdemers
left a comment
bdemers
left a comment
There was a problem hiding this comment.
Woot!
Make sure CI is green and merge it!
bretterer
approved these changes
Apr 29, 2020
Contributor
bretterer
left a comment
bretterer
left a comment
There was a problem hiding this comment.
Looks good to me. Lots of work has been done here! Thanks!
impl/src/main/java/com/okta/sdk/impl/http/authc/OAuth2RequestAuthenticator.java
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java
Show resolved
Hide resolved
impl/src/main/java/com/okta/sdk/impl/oauth2/AccessTokenRetrieverServiceImpl.java
Show resolved
Hide resolved
laura-rodriguez
approved these changes
Apr 29, 2020
laura-rodriguez
left a comment
laura-rodriguez
left a comment
There was a problem hiding this comment.
A couple of minor notes but overall it looks good!
…taken care in a new PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.