Skip to content

OKTA859222 - Cleanup unused code in DefaultClientBuilder#build method (ClientCredentialsResolver) #1614

Merged
prachi-okta merged 1 commit intomasterfrom
okta859222_code_cleanup
Mar 26, 2025
Merged

OKTA859222 - Cleanup unused code in DefaultClientBuilder#build method (ClientCredentialsResolver) #1614
prachi-okta merged 1 commit intomasterfrom
okta859222_code_cleanup

Conversation

@prachi-okta
Copy link
Copy Markdown
Contributor

@prachi-okta prachi-okta commented Mar 26, 2025 •
edited
Loading

Issue(s)

Code cleanup unused code in DefaultClientBuilder#build method (ClientCredentialsResolver)
Address Question/Chore: unused code in DefaultClientBuilder#build method (ClientCredentialsResolver) · Issue #1575 · okta/okta-sdk-java

Description

Category

  • Bugfix
  • Enhancement
  • New Feature
  • Library Upgrade
  • Configuration Change
  • Versioning Change
  • Unit or Integration Test(s)
  • Documentation

Signoff

  • I have submitted a CLA for this PR
  • Each commit message explains what the commit does
  • I have updated documentation to explain what my PR does
  • My code is covered by tests if required
  • I did not edit any automatically generated files

@prachi-okta prachi-okta changed the title code clean up OKTA859222 - Cleanup unused code in DefaultClientBuilder#build method (ClientCredentialsResolver) Mar 26, 2025
@aniket-okta
Copy link
Copy Markdown

aniket-okta commented Mar 26, 2025 •
edited
Loading

@prachi-okta Please merge your previous pull request first and then rebase this. It would require another review.

@prachi-okta
Copy link
Copy Markdown
Contributor Author

prachi-okta commented Mar 26, 2025

@prachi-okta Please merge your previous pull request first and then rebase this. It would require another review.

no rebase would be required since the changes are in different files

@prachi-okta prachi-okta merged commit 5702011 into master Mar 26, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aniket-okta aniket-okta aniket-okta approved these changes

@pranav-okta pranav-okta Awaiting requested review from pranav-okta

@aditya-okta aditya-okta Awaiting requested review from aditya-okta

@BinoyOza-okta BinoyOza-okta Awaiting requested review from BinoyOza-okta

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prachi-okta @aniket-okta