multipart/form-data support added for file upload operations#66
Merged
sergiishamrai-okta merged 6 commits intomasterfrom Dec 13, 2021
Merged
multipart/form-data support added for file upload operations#66sergiishamrai-okta merged 6 commits intomasterfrom
sergiishamrai-okta merged 6 commits intomasterfrom
Conversation
sergiishamrai-okta
requested review from
VitaliiTytarenko-okta and
arvindkrishnakumar-okta
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
============================================
+ Coverage 60.80% 63.73% +2.93%
- Complexity 740 768 +28
============================================
Files 39 39
Lines 2707 2741 +34
Branches 505 510 +5
============================================
+ Hits 1646 1747 +101
+ Misses 886 810 -76
- Partials 175 184 +9
Continue to review full report at Codecov.
|
http/okhttp/src/main/java/com/okta/commons/http/okhttp/OkHttpRequestExecutor.java
Outdated
Show resolved
Hide resolved
http/okhttp/src/main/java/com/okta/commons/http/okhttp/OkHttpRequestExecutor.java
Outdated
Show resolved
Hide resolved
http/okhttp/src/test/groovy/com/okta/commons/http/okhttp/OkHttpRequestExecutorTest.groovy
Outdated
Show resolved
Hide resolved
arvindkrishnakumar-okta
approved these changes
Dec 10, 2021
Contributor
|
Did anything need to change for Apache HttpClient? |
Contributor
Author
We use OkHttp3 client in Java Mgmt SDK so no changes are required in Apache HttpClient |
Contributor
|
@sergiishamrai-okta customers have a choice between ok-http and Apache http-client. Any features added to one client must be added to the other. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to have the ability to upload files, so POST multipart/form-data support added
Origin: OKTA-448365
Related PR: okta/okta-sdk-java#679