Fix: Include [Okta.AspNet] project in CircleCI builds for complete package deployment #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinoyOza-okta
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
Okta.AspNetNuGet package was not being created or deployed to Artifactory during CircleCI builds. OnlyOkta.AspNet.AbstractionsandOkta.AspNetCorepackages were being pushed, causing deployment failures.Root Cause
The
netCoreProjectslist inbuild.cakewas missing theOkta.AspNetandOkta.AspNet.Testprojects. WhenCIRCLE_CI=True, the build system uses only thenetCoreProjectslist, effectively excludingOkta.AspNetfrom:Solution
Added
Okta.AspNetandOkta.AspNet.Testto thenetCoreProjectslist to ensure they are included in CircleCI builds.Changes
build.cakeline 22-27 to includeOkta.AspNetandOkta.AspNet.Testin thenetCoreProjectslistExpected Outcome
CircleCI builds will now generate and deploy all three packages:
Okta.AspNet.Abstractions.x.x.x.nupkgOkta.AspNet.x.x.x.nupkg(now included)Okta.AspNetCore.x.x.x.nupkgTesting
The fix can be verified by checking that the
artifactsdirectory contains all three.nupkgfiles after a CircleCI build completes.Fixes deployment issues where
Okta.AspNetpackage was missing from Artifactory pushes.