Repository navigation
Commit 11522a0
committed
Move iOS compile benchmarks to Mac_benchmark and pin Mac_benchmark to M1
Part of flutter#186414
The iOS compile benchmarks (basic_material_app_ios__compile,
flutter_gallery_ios__compile, hello_world_ios__compile and
imitation_game_flutter__compile) only run `flutter build ios`; they never
launch an app on the attached iPhone. Running them on `Mac_arm64_ios`
ties up physical devices and, because that pool mixes M1 and M4 Pro
hosts, splits every metric into two disconnected series on Skia Perf
(device_type=iPhone_11 vs iPhone_16_Pro) with a ~40-60% timing gap
between them.
Per the review discussion on flutter#186414, instead of moving them to the
unpinned `Mac_arm64` pool:
* Re-point the shared `mac_benchmark` platform from the Intel
`Macmini8,1` (being turned down, flutter.dev/go/macos-intel-deprecation)
to the Apple Silicon M1 `Macmini9,1` and add `cpu: arm64`.
* Move the four iOS compile benchmarks to `Mac_benchmark` with
`bringup: true`. They inherit `device_type: none` and the
`["devicelab", "hostonly", "mac", "arm64"]` tags from the platform
(dropping the `ios` tag also stops the recipe from running
`ideviceinfo`, which would fail on a host-only bot).
`flutter_gallery_ios__compile` keeps the `ruby` dependency for
CocoaPods, like `flutter_gallery_macos__compile`.
`imitation_game_swiftui` stays on `Mac_arm64_ios` because it runs
`xcodebuild test` against a physical device.
Note that every existing `Mac_benchmark` target moves from Intel to M1
hardware as part of this change, so their benchmark baselines will
shift once this lands.1 parent 8b2d89c commit 11522a0
1 file changed
Lines changed: 19 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
215 | 220 | | |
216 | 221 | | |
217 | | - | |
| 222 | + | |
218 | 223 | | |
219 | 224 | | |
220 | 225 | | |
| |||
5362 | 5367 | | |
5363 | 5368 | | |
5364 | 5369 | | |
5365 | | - | |
| 5370 | + | |
5366 | 5371 | | |
5367 | 5372 | | |
| 5373 | + | |
5368 | 5374 | | |
5369 | 5375 | | |
5370 | | - | |
5371 | | - | |
5372 | 5376 | | |
5373 | 5377 | | |
5374 | 5378 | | |
| |||
5472 | 5476 | | |
5473 | 5477 | | |
5474 | 5478 | | |
5475 | | - | |
| 5479 | + | |
5476 | 5480 | | |
5477 | 5481 | | |
| 5482 | + | |
5478 | 5483 | | |
5479 | 5484 | | |
5480 | | - | |
5481 | | - | |
| 5485 | + | |
| 5486 | + | |
| 5487 | + | |
| 5488 | + | |
5482 | 5489 | | |
5483 | 5490 | | |
5484 | 5491 | | |
| |||
5499 | 5506 | | |
5500 | 5507 | | |
5501 | 5508 | | |
5502 | | - | |
| 5509 | + | |
5503 | 5510 | | |
5504 | 5511 | | |
| 5512 | + | |
5505 | 5513 | | |
5506 | 5514 | | |
5507 | | - | |
5508 | | - | |
5509 | 5515 | | |
5510 | 5516 | | |
5511 | | - | |
| 5517 | + | |
5512 | 5518 | | |
5513 | 5519 | | |
| 5520 | + | |
5514 | 5521 | | |
5515 | 5522 | | |
5516 | | - | |
5517 | | - | |
5518 | 5523 | | |
5519 | 5524 | | |
5520 | 5525 | | |
| |||
0 commit comments