refactor: extract ZstdDecompressionMiddleware out of create_app()#6174
Merged
mattf merged 1 commit intoJun 26, 2026
Merged
Conversation
Move the ZstdDecompressionMiddleware ASGI middleware from the create_app() function body to the module level, making it a standalone, importable class with a docstring. This improves testability, adheres to the convention of top-level classes, and matches the pattern used by ProviderDataMiddleware above it. Signed-off-by: Matthew Farrellee <[email protected]>
mattf
marked this pull request as ready for review
June 23, 2026 20:08
mattf
requested review from
bbrowning,
cdoern,
franciscojavierarceo,
leseb,
raghotham and
skamenan7
as code owners
June 23, 2026 20:08
franciscojavierarceo
approved these changes
Jun 24, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the ZstdDecompressionMiddleware ASGI middleware from the create_app() function body to the module level, making it a standalone, importable class with a docstring.
This improves testability, adheres to the convention of top-level classes, and matches the pattern used by ProviderDataMiddleware above it.