Repository navigation
fix: stop status polling from cancelling running scheduled tasks - #5789
Merged
Merged
Conversation
github-actions
Bot
added
needs work
3 tasks done
Contributor
Author
|
Friendly bump -- let me know if anything needs changing. |
3 tasks done
Contributor
Author
|
Friendly bump -- let me know if anything needs changing. |
…tasks Two paths caused the scheduler to interrupt a running background task when the frontend Activity view polled for status: 1. GET /api/tasks/runs/recent was not in _PASSIVE_EXACT_PATHS, so _InteractiveActivityMiddleware treated it as a foreground request and called stop_background_tasks_for_foreground, cancelling any in-flight scheduled task. Add it to _PASSIVE_EXACT_PATHS alongside the other read-only polling endpoints. 2. The /api/activity/heartbeat handler called stop_background_tasks_for_foreground unconditionally, ignoring BACKGROUND_TASK_FOREGROUND_GATE=false. Wrap the call in a _gate_enabled() guard so the env var fully disables heartbeat- triggered cancellations. Fixes odysseus-dev#5782 Signed-off-by: Christian Sidak <[email protected]> Signed-off-by: Christian-Sidak <[email protected]>
alteixeira20
force-pushed
the
fix/issue-5782
branch
from
August 14, 2026 09:47
10847bb to
01a8d08
Compare
alteixeira20
approved these changes
Aug 14, 2026
alteixeira20
left a comment
alteixeira20
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed and updated against current dev. The task-status polling endpoint is now correctly classified as passive, the browser heartbeat respects BACKGROUND_TASK_FOREGROUND_GATE, the heartbeat policy has direct behavioral regression coverage, and the updated CI/security suite is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fixes #5782
Type of Change
Summary
Two paths caused the scheduler to cancel a running background task the moment the frontend Activity view polled for status.
Bug 1: GET /api/tasks/runs/recent was not in _PASSIVE_EXACT_PATHS in src/interactive_gate.py. The _InteractiveActivityMiddleware treated it as a foreground request and called stop_background_tasks_for_foreground, cancelling any in-flight task immediately. Added it to _PASSIVE_EXACT_PATHS alongside the other read-only polling endpoints.
Bug 2: The /api/activity/heartbeat handler called stop_background_tasks_for_foreground unconditionally, ignoring BACKGROUND_TASK_FOREGROUND_GATE=false. The call is now guarded by _gate_enabled().
Both issues combined to produce the log pattern from the issue:
Checklist
How to Test
Unit-level: python -c "import src.interactive_gate as ig; assert not ig.should_track_interactive_request('/api/tasks/runs/recent', 'GET'); print('OK')"