This is cool! 🎸

Are we supposed to have one of them be the "deprecated" flavor? I mean it because the code seems like the "ugly" kid is SavepointCase, but we've been doing efforts to migrate to SavepointCase since long ago, and it wouldn't be nice 😋

Great initiative!

Are we supposed to have one of them be the "deprecated" flavor? I mean it because the code seems like the "ugly" kid is SavepointCase, but we've been doing efforts to migrate to SavepointCase since long ago, and it wouldn't be nice yum

Yeah that would be nice: keep SavepointCase class for a while and just deprecate it. It will help to not make all test suite break at once.

@Julien00859 I added the deprecation warning.
This forces me to replace all occurrences of SavepointCase by TransactionCase.

@robodoo rebase-ff r+

Merge method set to rebase and fast-forward

Well, my suggestion was more to deprecate TransactionCase. Otherwise we are supposed to use SavepointCase in Odoo 12-14 codebases, and then later on Odoo 15+ change it back to TransactionCase again. Going forward and backwards is not cool 😢

@rco-odoo @simahawk A good point should to improve common classes in order not to inherit from TransactionCase by default as it does not allow to inherit from it without launching all the test suites that inherit also.

IMHO the AccountInvoicingCommon class should inherit from nothing as it is there to create data and so on. Only tests classes that have 'test_' functions should inherit from TransactionCase.

https://github.com/odoo/odoo/blame/master/addons/account/tests/common.py#L11

Hi @rco-odoo

I enriched the def action_signed(self) from the enterprise sign module for my customer.
In this fonction we have this line self.env.cr.commit()

def action_signed(self):
        self.write({'state': 'signed'})
        **self.env.cr.commit()**
        if not self.check_is_encrypted():
            # if the file is encrypted, we must wait that the document is decrypted
            self.send_completed_document()

When I run my test I see that the system is unable to rollback what have been done in the test because of the commit inside de action_signed.

I see in the sign tests the action_signed is not used. The workarround is a simple write state...

# sign the document
request_item.write({'state': 'completed'})

Do you have an idea to get rid of it ?

@tfossoul committing in the middle of a request is bad practice. You could try to avoid that commit by moving the subsequent action into a post-commit hook (cr.postcommit.add()). Post-commit hooks are never run by tests, simply because the cursor is never committed. This works well when the action sends some message to some 3rd party service.

If you cannot remove that commit statement, then I see two other possible solutions:

• in the code itself, do not commit if the current thread is in "test" mode, like in https://github.com/odoo/odoo/blob/15.0/addons/crm/models/crm_lead.py#L2094
• in the test code, run the code to test with an environment that uses a TestCursor; this trick is used by HTTP tests to do everything inside the main cursor without actually committing it.

@rco-odoo The "self.env.cr.commit()" line is part of odoo enterprise addons ;)

I suspect the cr.commit is done before trying to send completed document by mail synchronously via the force_send option of _message_send_mail function
Don't think it is usefull to force send the mails..