[FIX] Python 3.13 / Debian Trixie compatibility #219300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Contributor
Author
|
@xmo-odoo cherrypicking of pull request #219270 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
robodoo
added
forwardport
`importlib.metadata.version` was made final (non-provisional) in Python 3.10 which is the minver for odoo 18 so no need for a conditional.
When 3.11 added PEP 657 fine-grained error locations, squiggles were already possible[^1] but apparently we missed that in the cleanup regex because those didn't show up in the messages we cared about. With Python 3.13's improvements (sic...)[^2] this is not the case anymore, and the tracebacks from testing the test suite do get a bunch of squiggles which we need to learn to clean. [^1]: https://docs.python.org/3/whatsnew/3.11.html#whatsnew311-pep657 [^2]: https://docs.python.org/3/whatsnew/3.13.html#improved-error-messages
Some libraries need to be bumped to be compatible with Python 3.13 (as used in Trixie). In that case we update the requirements to the Trixie version if possible, even if a lower version would be compatible with 3.13 itself. - babel needs to be at least [2.11 to avoid usage of cgi][2] removed from 3.13 - freezegun needs to be [at least 1.5.0][3] to not call the now-removed `uuid._load_system_functions()` - trixie ships gevent 24.11.1 and greenlet 3.1.0, but upstream [gevent 24.11.1 requires greenlet 3.1.1][1] so basing the requirements off of trixie doesn't even install - zeep needs to be [at least 4.3.0][4] to not use the `cgi` module [1]: https://github.com/gevent/gevent/blob/24.11.1/setup.py#L200-L214 [2]: https://babel.pocoo.org/en/latest/changelog.html#version-2-11-0 [3]: spulec/freezegun#534 [4]: mvantellingen/python-zeep#1364
python/cpython#131568 Adapt the regex to handle both < 3.13 and >= 3.13 for this specific test case.
Need to accept and forward size parameters in `addBlankPage`, used by a test for some reason.
xmo-odoo
force-pushed
the
18.0-17.0-trixie-compat-xmo-450646-fw
branch
from
37b60ef to
dbd39ee
Compare
C3POdoo
requested review from
a team,
Gorash,
Julien00859 and
ryv-odoo
and removed request for
a team
Collaborator
|
@robodoo r+ |
Contributor
|
@xmo-odoo you may want to rebuild or fix this PR as it has failed CI. |
robodoo
pushed a commit
that referenced
this pull request
Jul 17, 2025
Part-of: #219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jul 17, 2025
`importlib.metadata.version` was made final (non-provisional) in Python 3.10 which is the minver for odoo 18 so no need for a conditional. Part-of: #219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jul 17, 2025
When 3.11 added PEP 657 fine-grained error locations, squiggles were already possible[^1] but apparently we missed that in the cleanup regex because those didn't show up in the messages we cared about. With Python 3.13's improvements (sic...)[^2] this is not the case anymore, and the tracebacks from testing the test suite do get a bunch of squiggles which we need to learn to clean. [^1]: https://docs.python.org/3/whatsnew/3.11.html#whatsnew311-pep657 [^2]: https://docs.python.org/3/whatsnew/3.13.html#improved-error-messages Part-of: #219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jul 17, 2025
Some libraries need to be bumped to be compatible with Python 3.13 (as used in Trixie). In that case we update the requirements to the Trixie version if possible, even if a lower version would be compatible with 3.13 itself. - babel needs to be at least [2.11 to avoid usage of cgi][2] removed from 3.13 - freezegun needs to be [at least 1.5.0][3] to not call the now-removed `uuid._load_system_functions()` - trixie ships gevent 24.11.1 and greenlet 3.1.0, but upstream [gevent 24.11.1 requires greenlet 3.1.1][1] so basing the requirements off of trixie doesn't even install - zeep needs to be [at least 4.3.0][4] to not use the `cgi` module [1]: https://github.com/gevent/gevent/blob/24.11.1/setup.py#L200-L214 [2]: https://babel.pocoo.org/en/latest/changelog.html#version-2-11-0 [3]: spulec/freezegun#534 [4]: mvantellingen/python-zeep#1364 Part-of: #219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jul 17, 2025
python/cpython#131568 Adapt the regex to handle both < 3.13 and >= 3.13 for this specific test case. Part-of: #219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Jul 17, 2025
Need to accept and forward size parameters in `addBlankPage`, used by a test for some reason. Part-of: #219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
robodoo
added a commit
that referenced
this pull request
Jul 23, 2025
closes #219478 Forward-port-of: #219300 Forward-port-of: #219270 Related: odoo/enterprise#90447 Signed-off-by: Xavier Morel (xmo) <[email protected]>
yodalberth
pushed a commit
to yodalberth/ERP_EMPRESAS
that referenced
this pull request
Jul 26, 2025
Part-of: odoo#219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
yodalberth
pushed a commit
to yodalberth/ERP_EMPRESAS
that referenced
this pull request
Jul 26, 2025
`importlib.metadata.version` was made final (non-provisional) in Python 3.10 which is the minver for odoo 18 so no need for a conditional. Part-of: odoo#219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
yodalberth
pushed a commit
to yodalberth/ERP_EMPRESAS
that referenced
this pull request
Jul 26, 2025
When 3.11 added PEP 657 fine-grained error locations, squiggles were already possible[^1] but apparently we missed that in the cleanup regex because those didn't show up in the messages we cared about. With Python 3.13's improvements (sic...)[^2] this is not the case anymore, and the tracebacks from testing the test suite do get a bunch of squiggles which we need to learn to clean. [^1]: https://docs.python.org/3/whatsnew/3.11.html#whatsnew311-pep657 [^2]: https://docs.python.org/3/whatsnew/3.13.html#improved-error-messages Part-of: odoo#219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
yodalberth
pushed a commit
to yodalberth/ERP_EMPRESAS
that referenced
this pull request
Jul 26, 2025
Some libraries need to be bumped to be compatible with Python 3.13 (as used in Trixie). In that case we update the requirements to the Trixie version if possible, even if a lower version would be compatible with 3.13 itself. - babel needs to be at least [2.11 to avoid usage of cgi][2] removed from 3.13 - freezegun needs to be [at least 1.5.0][3] to not call the now-removed `uuid._load_system_functions()` - trixie ships gevent 24.11.1 and greenlet 3.1.0, but upstream [gevent 24.11.1 requires greenlet 3.1.1][1] so basing the requirements off of trixie doesn't even install - zeep needs to be [at least 4.3.0][4] to not use the `cgi` module [1]: https://github.com/gevent/gevent/blob/24.11.1/setup.py#L200-L214 [2]: https://babel.pocoo.org/en/latest/changelog.html#version-2-11-0 [3]: spulec/freezegun#534 [4]: mvantellingen/python-zeep#1364 Part-of: odoo#219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
yodalberth
pushed a commit
to yodalberth/ERP_EMPRESAS
that referenced
this pull request
Jul 26, 2025
python/cpython#131568 Adapt the regex to handle both < 3.13 and >= 3.13 for this specific test case. Part-of: odoo#219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
yodalberth
pushed a commit
to yodalberth/ERP_EMPRESAS
that referenced
this pull request
Jul 26, 2025
Need to accept and forward size parameters in `addBlankPage`, used by a test for some reason. Part-of: odoo#219300 Related: odoo/enterprise#90362 Signed-off-by: Xavier Morel (xmo) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-Port-Of: #219270