Skip to content

feat: add x-accepted-github-permissions#609

Merged
nickfloyd merged 1 commit intooctokit:mainfrom
jsoref:issue-607
Feb 15, 2024
Merged

feat: add x-accepted-github-permissions#609
nickfloyd merged 1 commit intooctokit:mainfrom
jsoref:issue-607

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Feb 15, 2024

https://docs.github.com/en/rest/using-the-rest-api/troubleshooting-the-rest-api?apiVersion=2022-11-28#resource-not-accessible

Resolves #607


Before the change?

  • x-accepted-github-permissions header isn't exposed

After the change?

  • x-accepted-github-permissions will hopefully be exposed

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@nickfloyd nickfloyd added the Type: Feature New feature or request label Feb 15, 2024
Copy link
Copy Markdown
Contributor

@nickfloyd nickfloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jsoref thanks for the contributions here! ❤️

@nickfloyd nickfloyd merged commit bc28bdc into octokit:main Feb 15, 2024
@octokitbot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 12.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Feature New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: ResponseHeaders doesn't have x-accepted-github-permissions

3 participants