Skip to content

feat: remove previews#546

Merged
wolfy1339 merged 3 commits intobetafrom
remove-previews
May 25, 2023
Merged

feat: remove previews#546
wolfy1339 merged 3 commits intobetafrom
remove-previews

Conversation

@wolfy1339
Copy link
Copy Markdown
Member

@wolfy1339 wolfy1339 commented May 22, 2023

Resolves #ISSUE_NUMBER

Behavior

Before the change?

  • Previews have been removed, as they are only used for the GraphQL api, and were used for GHES versions up to 3.2

After the change?

  • Remove the previews from this repo

Other information

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added Type: Feature New feature or request Type: Breaking change Used to note any change that requires a major version bump labels May 22, 2023
@wolfy1339
Copy link
Copy Markdown
Member Author

wolfy1339 commented May 23, 2023

I figured the easiest path forward is to simply leave the previews types for RequestParameters and EndpointDefaults but mark them as optional.

@wolfy1339 wolfy1339 marked this pull request as ready for review May 23, 2023 21:49
@wolfy1339 wolfy1339 requested a review from gr2m May 23, 2023 21:49
@nickfloyd
Copy link
Copy Markdown
Contributor

nickfloyd commented May 25, 2023

@wolfy1339 When you are ready to pull the trigger - I'm assuming you were waiting on this before resolving all of the other breaking change PRs - I believe they are all approved and are ready to be merged in the order specified here.

I'll take one last look at all the leaf repos to make sure - but we are g2g for merge on the node and this breaking change. Please let me know what you think.

Thanks again for all the work on this! ❤️

@wolfy1339 wolfy1339 merged commit 702b1fc into beta May 25, 2023
@wolfy1339 wolfy1339 deleted the remove-previews branch May 25, 2023 16:08
@octokitbot
Copy link
Copy Markdown
Contributor

octokitbot commented May 25, 2023

🎉 This PR is included in version 9.3.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wolfy1339
Copy link
Copy Markdown
Member Author

wolfy1339 commented May 25, 2023

I'm merging this into the beta branch so it can be tested a little with the other leaf repos before it goes to stable.

@wolfy1339
Copy link
Copy Markdown
Member Author

wolfy1339 commented May 25, 2023

Ah shucks! Forgot to add BREAKING CHANGE.
Good thing it's only the beta branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gr2m gr2m Awaiting requested review from gr2m

1 more reviewer

@nickfloyd nickfloyd nickfloyd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released on @beta Type: Breaking change Used to note any change that requires a major version bump Type: Feature New feature or request

Projects

🧰 Octokit Active
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wolfy1339 @nickfloyd @octokitbot