Skip to content

test: re-activate more tests and convert them to typescript#457

Merged
wolfy1339 merged 22 commits intooctokit:mainfrom
Uzlopak:activate-tests
Jul 18, 2024
Merged

test: re-activate more tests and convert them to typescript#457
wolfy1339 merged 22 commits intooctokit:mainfrom
Uzlopak:activate-tests

Conversation

@Uzlopak
Copy link
Copy Markdown
Contributor

@Uzlopak Uzlopak commented Jul 17, 2024 •
edited by wolfy1339
Loading

WIP
Closes #414
Does not fix the tests from #441

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 17, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 changed the title fix: activate more tests test: re-activate more tests and convert them to typescript Jul 17, 2024
@wolfy1339 wolfy1339 self-assigned this Jul 17, 2024
@wolfy1339 wolfy1339 marked this pull request as draft July 17, 2024 00:19
@wolfy1339 wolfy1339 removed their assignment Jul 17, 2024
@Uzlopak Uzlopak marked this pull request as ready for review July 18, 2024 18:20
@Uzlopak
Copy link
Copy Markdown
Contributor Author

Uzlopak commented Jul 18, 2024

I am exhausted by this PR. So I provide it to you for strict PR review.

wolfy1339
wolfy1339 reviewed Jul 18, 2024
View reviewed changes
Comment thread test/issues/1279-store-otp-send-header-all-requests.test.ts Outdated
wolfy1339
wolfy1339 reviewed Jul 18, 2024
View reviewed changes
Comment thread test/scenarios/get-archive.test.ts
Copy link
Copy Markdown
Member

@wolfy1339 wolfy1339 Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you take a look a these tests?

Copy link
Copy Markdown
Contributor Author

@Uzlopak Uzlopak Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think there is some problems with the fixtures imho

@wolfy1339 wolfy1339 merged commit 5a4eeb6 into octokit:main Jul 18, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 16, 2024

🎉 This issue has been resolved in version 21.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfy1339 wolfy1339 wolfy1339 approved these changes

Assignees

No one assigned

Labels

released

Projects

🧰 Octokit Active
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Uzlopak @wolfy1339