fix(fetch-wrapper): improve error message when 'fetch' implementation is not present (#617)

oscard0m · web-flow · commit a83722cab460 · 2023-07-18T17:28:19.000-07:00
chore(fetch-wrapper): improve error message when 'fetch' implementation is not present
diff --git a/src/fetch-wrapper.ts b/src/fetch-wrapper.ts
@@ -32,7 +32,7 @@ export default function fetchWrapper(
 
   if (!fetch) {
     throw new Error(
-      'Global "fetch" not found. Please provide `options.request.fetch` to octokit or upgrade to node@18 or newer.',
+      "fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing",
     );
   }
 
diff --git a/test/request.test.ts b/test/request.test.ts
@@ -396,7 +396,7 @@ x//0u+zd/R/QRUzLOw4N72/Hu+UG6MNt5iDZFCtapRaKt6OvSBwy8w==
     }
     globalThis.fetch = originalFetch;
     expect(error?.message).toEqual(
-      'Global "fetch" not found. Please provide `options.request.fetch` to octokit or upgrade to node@18 or newer.',
+      "fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing",
     );
   });
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ export default function fetchWrapper(`
`32`	`32`
`33`	`33`	`if (!fetch) {`
`34`	`34`	`throw new Error(`
`35`		- 'Global "fetch" not found. Please provide `options.request.fetch` to octokit or upgrade to node@18 or newer.',
	`35`	`+ "fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing",`
`36`	`36`	`);`
`37`	`37`	`}`
`38`	`38`
Original file line number	Diff line number	Diff line change
`@@ -396,7 +396,7 @@ x//0u+zd/R/QRUzLOw4N72/Hu+UG6MNt5iDZFCtapRaKt6OvSBwy8w==`
`396`	`396`	`}`
`397`	`397`	`globalThis.fetch = originalFetch;`
`398`	`398`	`expect(error?.message).toEqual(`
`399`		- 'Global "fetch" not found. Please provide `options.request.fetch` to octokit or upgrade to node@18 or newer.',
	`399`	`+ "fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing",`
`400`	`400`	`);`
`401`	`401`	`});`
`402`	`402`