Repository navigation
Commit 554e102
authored
fix: handle primitive JSON error bodies without throwing (#820)
When an HTTP error response has `content-type: application/json` but the
JSON body is a primitive (`null`, a number, a boolean), `toErrorMessage()`
threw a raw `TypeError` from `"message" in data` before `RequestError` was
constructed, so callers lost the `status`, `request`, and `response` fields.
Guard the object-shaped branch with `typeof data === "object" && data !== null`
so primitives fall through to the generic `Unknown error: ...` message and a
proper `RequestError` is thrown. Also widen the parameter type to `unknown`,
which reflects that the parsed body can be any JSON value.
Fixes #8191 parent 14cf144 commit 554e102
2 files changed
Lines changed: 45 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
| 193 | + | |
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
| |||
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
202 | | - | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
203 | 208 | | |
204 | | - | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
205 | 212 | | |
206 | | - | |
207 | | - | |
208 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
209 | 216 | | |
210 | 217 | | |
211 | 218 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1293 | 1293 | | |
1294 | 1294 | | |
1295 | 1295 | | |
| 1296 | + | |
| 1297 | + | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
| 1323 | + | |
| 1324 | + | |
| 1325 | + | |
| 1326 | + | |
| 1327 | + | |
1296 | 1328 | | |
1297 | 1329 | | |
1298 | 1330 | | |
| |||
0 commit comments