fix: don't deadlock on 10+ concurrent requests needing auth #779
Conversation
|
Can you update the PR with octokit/auth-app.js#689 |
give auth requests a dedicated queue, so that they don't cause a deadlock when too many requests are queued
jenseng
force-pushed
the
fix-auth-deadlock
branch
from
22fd013 to
16d260b
Compare
Done! I only updated the dev dependency and the test, since it can still work with older versions (just suboptimally). Let me know if we should tweak peerDependencies/etc too |
|
🎉 This PR is included in version 9.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Great work on adding custom throttling for auth requests 🚀 |
|
@gr2m @wolfy1339 @jenseng is it possible to backport this fix to CJS v8 version of the package? |
|
Unfortunately not. With recent developments on Besides, the Octokit packages don't have an active maintainer team at all. |
4 participants
Fixes #754
Fixes octokit/octokit.js#2800
Give auth requests a dedicated queue. This ensures that they don't cause a deadlock when 10+ concurrent requests are made that need authentication (i.e. either we've never authed, or the token has expired).