fix(engines): Revert engine back to 16#432
Merged
wolfy1339 merged 2 commits intooctokit:mainfrom Jun 2, 2023
Merged
Conversation
octokit#430 upgraded the Node version to 18, but as a fix (instead of a breaking change). So it breaks consumers of the library (such as [`semantic-release`](https://github.com/semantic-release/semantic-release)) that are still on Node 16. Fixes octokit#431
1 task
Member
|
Can you also update the build script: |
Contributor
Author
done and done! |
wolfy1339
approved these changes
Jun 2, 2023
|
🎉 This PR is included in version 4.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Contributor
Author
|
Thanks for being so responsive @wolfy1339! 🎉 Such a quick turnaround 🙏🏾 |
Contributor
Author
|
Verified that |
5 tasks
This was referenced Sep 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#430 upgraded the Node version to 18, but as a fix released in
4.1.4(instead of as a breaking change). So it breaks consumers of the library (such assemantic-release) that are still on Node 16.Resolves #431
Behavior
Before the change?
@ocktokit/plugin-retrywith Node 16.After the change?
@ocktokit/plugin-retrywith Node 16 because it requires Node 18.Other information
n/a
Additional info
Pull request checklist
Does this introduce a breaking change?
It doesn't. The previous PR did
Please see our docs on breaking changes to help!
Type: Breaking changelabel)If
Yes, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: BugType: FeatureType: DocumentationType: Maintenance