What happened?
In https://github.com/github/vscode-codeql/blob/main/extensions/ql-vscode/src/databases/code-search-api.ts we're using octokit.paginate.iterator(octokit.rest.search.code) and on the response we're checking response.data.total_count. In the upgrade from 21.0.2 to 21.1.0 this field seems to have disappeared. It's still there in the response from GitHub (i.e. making the request with curl) but it gets deleted before it reaches our code.
We're wondering if this change came from #637 but we're not sure and also check if this was an intentional effect or not. Alternatively, is there another recommended way to access the total_count field?
Versions
@octokit/rest v21.1.0
Relevant log output
Code of Conduct
What happened?
In https://github.com/github/vscode-codeql/blob/main/extensions/ql-vscode/src/databases/code-search-api.ts we're using
octokit.paginate.iterator(octokit.rest.search.code)and on the response we're checkingresponse.data.total_count. In the upgrade from21.0.2to21.1.0this field seems to have disappeared. It's still there in the response from GitHub (i.e. making the request with curl) but it gets deleted before it reaches our code.We're wondering if this change came from #637 but we're not sure and also check if this was an intentional effect or not. Alternatively, is there another recommended way to access the
total_countfield?Versions
@octokit/rest v21.1.0
Relevant log output
Code of Conduct