Skip to content

build: disable generating generated/*.diff.json files#394

Merged
nickfloyd merged 4 commits intomainfrom
disable-anicca
Sep 22, 2023
Merged

build: disable generating generated/*.diff.json files#394
nickfloyd merged 4 commits intomainfrom
disable-anicca

Conversation

@wolfy1339
Copy link
Copy Markdown
Member

Resolves #391


Before the change?

  • The update workflow would fail because anicca is no longer able to generate diff files

After the change?

  • Generating the diff files is now disabled

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Sep 16, 2023
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 requested a review from gr2m September 16, 2023 19:49
nickfloyd
nickfloyd previously approved these changes Sep 18, 2023
Comment thread .github/workflows/update.yml
Comment thread .github/workflows/update.yml Outdated
@nickfloyd nickfloyd merged commit b26a403 into main Sep 22, 2023
@nickfloyd nickfloyd deleted the disable-anicca branch September 22, 2023 18:40
@octokitbot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 12.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[MAINT]: build fails during anicca step

4 participants