fix: add override for /app/installations/ response#388
Merged
wolfy1339 merged 4 commits intooctokit:mainfrom Sep 22, 2023
Merged
fix: add override for /app/installations/ response#388wolfy1339 merged 4 commits intooctokit:mainfrom
/app/installations/ response#388wolfy1339 merged 4 commits intooctokit:mainfrom
Conversation
Contributor
Author
|
I think the Dry-run is failing due to the build script not handling parsing the version from the filename correctly. I think the regex currently only supports a single digit for the two parts of the version and the download script has downloaded a file for v3.10. Version 3.10 is also not included in the SUPPORTED_GHES_OPERATIONS constant. Should I include fixes to those issue in this PR? |
Contributor
|
@Jman420 unfortunately that's affecting all the PRs at the moment. If you do fix that, would you mind using a separate PR? |
… be an allOf list instead of anyOf
Jman420
force-pushed
the
override/get-app-installations
branch
from
4b76972 to
a4ef13a
Compare
wolfy1339
previously approved these changes
Sep 15, 2023
wolfy1339
approved these changes
Sep 15, 2023
1 task
wolfy1339
changed the title
/app/installations/ response
Contributor
|
🎉 This PR is included in version 12.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add override for /app/installations/ response for account property to be an allOf list instead of anyOf
Resolves octokit/openapi-types.ts#305
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!