Problem
The override files for /app/installations (scripts/overrides/get-app-installations.json and .deref.json) contain a stale copy of the app-permissions schema that uses team_discussions instead of discussions.
The upstream source (github/rest-api-description) correctly has discussions in its app-permissions schema, but replaceOperation() in scripts/overrides/index.mjs overwrites it with the stale override copy.
Impact
Consumers of @octokit/openapi (e.g. actions/create-github-app-token) that auto-generate permission inputs from app-permissions end up with team_discussions instead of discussions, causing:
- Missing
permission-discussions input (users get "Unexpected input" warnings)
- Incorrect
permission-team-discussions present instead
Root Cause
The override files were created to fix a anyOf issue (see #305 on openapi-types.ts) but contain a frozen snapshot of the permissions schema from that time. As the upstream schema evolved (team_discussions → discussions), the overrides were never updated.
Fix
Update the two override files to replace team_discussions with discussions (matching the current upstream schema). Also update any other stale permissions that may have drifted.
PR incoming.
Problem
The override files for
/app/installations(scripts/overrides/get-app-installations.jsonand.deref.json) contain a stale copy of theapp-permissionsschema that usesteam_discussionsinstead ofdiscussions.The upstream source (
github/rest-api-description) correctly hasdiscussionsin itsapp-permissionsschema, butreplaceOperation()inscripts/overrides/index.mjsoverwrites it with the stale override copy.Impact
Consumers of
@octokit/openapi(e.g.actions/create-github-app-token) that auto-generate permission inputs fromapp-permissionsend up withteam_discussionsinstead ofdiscussions, causing:permission-discussionsinput (users get "Unexpected input" warnings)permission-team-discussionspresent insteadRoot Cause
The override files were created to fix a
anyOfissue (see #305 on openapi-types.ts) but contain a frozen snapshot of the permissions schema from that time. As the upstream schema evolved (team_discussions→discussions), the overrides were never updated.Fix
Update the two override files to replace
team_discussionswithdiscussions(matching the current upstream schema). Also update any other stale permissions that may have drifted.PR incoming.