[fix] Fix handling for Streams in IConnection for raw content#2791
Merged
kfcampbell merged 3 commits intooctokit:mainfrom Nov 7, 2023
martincostello:fix-stream-handling
Merged
[fix] Fix handling for Streams in IConnection for raw content#2791kfcampbell merged 3 commits intooctokit:mainfrom martincostello:fix-stream-handling
kfcampbell merged 3 commits intooctokit:mainfrom
martincostello:fix-stream-handling
Conversation
4 tasks
Contributor
Author
|
Looks like this got closed by accident because I put the wrong |
1 task
Contributor
Author
|
@nickfloyd Anything more you need from me to progress this fix? |
Contributor
|
I do think it'd be possible to write a test for this case in |
kfcampbell
approved these changes
Nov 7, 2023
Contributor
kfcampbell
left a comment
kfcampbell
left a comment
There was a problem hiding this comment.
Looks good, thank you!
Lulalaby
referenced
this pull request
in Fortunevale/ProjectMakoto
Jan 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [Octokit](https://togithub.com/octokit/octokit.net) | `9.0.0` -> `9.1.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>octokit/octokit.net (Octokit)</summary> ### [`v9.1.0`](https://togithub.com/octokit/octokit.net/releases/tag/v9.1.0) #### What's Changed ##### Features - \[feat]: Output GraphQL rate limit by [@​dirtygooback](https://togithub.com/dirtygooback) in [https://github.com/octokit/octokit.net/pull/2807](https://togithub.com/octokit/octokit.net/pull/2807) - \[feat]: Allow the constructor for `ProductHeaderValue` to accept a framework version of the object by [@​Cyberboss](https://togithub.com/Cyberboss) in [https://github.com/octokit/octokit.net/pull/2821](https://togithub.com/octokit/octokit.net/pull/2821) - \[feat] Introduce NewRelease.DiscussionCategoryName, Fixes [#​2746](https://togithub.com/octokit/octokit.net/issues/2746) by [@​AndreyAkinshin](https://togithub.com/AndreyAkinshin) in [https://github.com/octokit/octokit.net/pull/2842](https://togithub.com/octokit/octokit.net/pull/2842) - \[feat]: Adding Copilot for Business support by [@​dylan-asos](https://togithub.com/dylan-asos) in [https://github.com/octokit/octokit.net/pull/2826](https://togithub.com/octokit/octokit.net/pull/2826) - \[feat]: Implement Actions OIDC Client by [@​dirtygooback](https://togithub.com/dirtygooback) in [https://github.com/octokit/octokit.net/pull/2828](https://togithub.com/octokit/octokit.net/pull/2828) - \[feat] Add support for "Require approval of the most recent reviewable push" by [@​ChrisAnn](https://togithub.com/ChrisAnn) in [https://github.com/octokit/octokit.net/pull/2839](https://togithub.com/octokit/octokit.net/pull/2839) ##### Bugs - \[fix] Fix handling for Streams in IConnection for raw content by [@​martincostello](https://togithub.com/martincostello) in [https://github.com/octokit/octokit.net/pull/2791](https://togithub.com/octokit/octokit.net/pull/2791) - \[fix]: The methods `GetAllForCurrentWithTimestamps` and `GetAllForUserWithTimestamps` did not return timestamps. by [@​MareMare](https://togithub.com/MareMare) in [https://github.com/octokit/octokit.net/pull/2829](https://togithub.com/octokit/octokit.net/pull/2829) ##### Maintenance - build(deps): bump Microsoft.NET.Test.Sdk from 17.7.2 to 17.8.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/octokit/octokit.net/pull/2811](https://togithub.com/octokit/octokit.net/pull/2811) - build(deps): bump Microsoft.SourceLink.GitHub from 1.1.1 to 8.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/octokit/octokit.net/pull/2816](https://togithub.com/octokit/octokit.net/pull/2816) - build(deps): bump Microsoft.Bcl.AsyncInterfaces from 7.0.0 to 8.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/octokit/octokit.net/pull/2817](https://togithub.com/octokit/octokit.net/pull/2817) - build(deps): bump Cake.Frosting from 2.3.0 to 4.0.0 in /build by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/octokit/octokit.net/pull/2814](https://togithub.com/octokit/octokit.net/pull/2814) - build(deps): bump xunit from 2.6.3 to 2.6.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/octokit/octokit.net/pull/2841](https://togithub.com/octokit/octokit.net/pull/2841) - build(deps): bump xunit.runner.visualstudio from 2.5.5 to 2.5.6 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/octokit/octokit.net/pull/2840](https://togithub.com/octokit/octokit.net/pull/2840) - \[maint]: don't run immediate response on Actions- or octokitbot-driven changes by [@​octokitbot](https://togithub.com/octokitbot) in [https://github.com/octokit/octokit.net/pull/2819](https://togithub.com/octokit/octokit.net/pull/2819) - \[maint]: Workflows have changed by [@​octokitbot](https://togithub.com/octokitbot) in [https://github.com/octokit/octokit.net/pull/2830](https://togithub.com/octokit/octokit.net/pull/2830) #### New Contributors - [@​AndreyAkinshin](https://togithub.com/AndreyAkinshin) made their first contribution in [https://github.com/octokit/octokit.net/pull/2842](https://togithub.com/octokit/octokit.net/pull/2842) - [@​MareMare](https://togithub.com/MareMare) made their first contribution in [https://github.com/octokit/octokit.net/pull/2829](https://togithub.com/octokit/octokit.net/pull/2829) - [@​ChrisAnn](https://togithub.com/ChrisAnn) made their first contribution in [https://github.com/octokit/octokit.net/pull/2839](https://togithub.com/octokit/octokit.net/pull/2839) **Full Changelog**: octokit/octokit.net@v9.0.0...v9.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Fortunevale/ProjectMakoto). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoiZGV2In0=-->
This was referenced Feb 5, 2026
](https://renovatebot.com){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
NullReferenceExceptionif raw content was handled as a string rather than a stream byHttpClientAdapter.BuildResponse().I haven't added a test for this, but have validated that the apps that surfaced this issue are working when using a local build of Octokit including this change. If you can direct me to exactly where you'd like a test for this, I'll add one.
Resolves #2789
Before the change?
NullReferenceExceptionwould be thrown.After the change?
Pull request checklist
Does this introduce a breaking change?