Conversation
Contributor
|
Would these visibility changes be breaking? |
Contributor
Author
Not at all. They are the setters that should be internal to the model, and the fields already become immutable after hydration. So no breaking changes are happening here. |
timrogers
approved these changes
Sep 12, 2022
Contributor
Author
|
release_notes: Converts response model property accessors from protected to the more appropriate private for consistency |
4 tasks
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies in advance for the size of this PR. Fortunately, the change set is a redundant change across classes.
From the issue:
Notes about the changes in this PR:
The following models remain unchanged due to inheritance constraints (where the
protectedaccessor is required). We can evaluate these relationships either prior to or post generation (depending on if we approach the generation byte for byte or if it's a complete rewrite):