Skip to content

test: fix openssl warning#546

Merged
wolfy1339 merged 2 commits intomainfrom
fix-openssl-warning
Jan 18, 2023
Merged

test: fix openssl warning#546
wolfy1339 merged 2 commits intomainfrom
fix-openssl-warning

Conversation

@wolfy1339
Copy link
Copy Markdown
Member

@wolfy1339 wolfy1339 commented Jan 18, 2023

Resolves #489

Behavior

Before the change?

  • Tests would fail due to an error with the CA certificate on NodeJS v18

After the change?

  • Tests are now passing on NodeJS v18

Other information

Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 18, 2023
@wolfy1339 wolfy1339 changed the title Fix openssl warning test: fix openssl warning Jan 18, 2023
kfcampbell
kfcampbell approved these changes Jan 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind explaining briefly what you did to know that this was a certificate issue and the actions taken to regenerate them (e.g. do they need to be signed or recognized by a particular authority)?

I'm not sure if it's worth adding documentation to the repository but it would be nice to have a paper trail if we're investigating a similar issue in the future.

@wolfy1339
Copy link
Copy Markdown
Member Author

wolfy1339 commented Jan 18, 2023

Do you mind explaining briefly what you did to know that this was a certificate issue

I looked up the error, and it was pointing to a bad CA cert, something changed between OpenSSL 1.1 and 3.0

the actions taken to regenerate them (e.g. do they need to be signed or recognized by a particular authority)?

It is simply a self-signed certificate, not signed by any CA.

I'm not sure if it's worth adding documentation to the repository but it would be nice to have a paper trail if we're investigating a similar issue in the future.

There is a README file in that directory that has the instructions on how to regenerate them

@wolfy1339 wolfy1339 merged commit dfbdb2d into main Jan 18, 2023
@wolfy1339 wolfy1339 deleted the fix-openssl-warning branch January 18, 2023 21:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 20, 2023

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kfcampbell kfcampbell kfcampbell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Projects

🧰 Octokit Active
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests fail on Node v18

2 participants

@wolfy1339 @kfcampbell