Skip to content

fix(build): switch to esbuild and tsc from pika #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kfcampbell merged 14 commits into from
Jun 6, 2023
Merged

fix(build): switch to esbuild and tsc from pika #345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6b8c7e4
Switch to esbuild and tsc from pika
kfcampbell Jun 5, 2023
c93da37
Fix linting errors
kfcampbell Jun 5, 2023
c771f50
Merge branch 'main' into switch-to-esbuild
kfcampbell Jun 5, 2023
6e83fdd
Explicitly mark imports
kfcampbell Jun 5, 2023
04d5f09
Undo overzealous type import
kfcampbell Jun 5, 2023
e2790b9
npm i --save-dev @octokit/types
kfcampbell Jun 5, 2023
0cb4d2b
Use node 14 to create lockfile
kfcampbell Jun 5, 2023
d29f2d3
Redo appropriately zealous type import
kfcampbell Jun 5, 2023
b244ba2
Add --verbatimModuleSyntax build option
kfcampbell Jun 5, 2023
9a3587f
Move verbatimModuleSyntax to tsconfig
kfcampbell Jun 6, 2023
e644e94
Create tsconfig.test.json
kfcampbell Jun 6, 2023
01a7dc0
Bump version of octokit/tsconfig
kfcampbell Jun 6, 2023
2541524
Update tsconfig.test.json
kfcampbell Jun 6, 2023
4d6cd2a
Move tsconfig.test.json to test directory
kfcampbell Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move verbatimModuleSyntax to tsconfig
  • Loading branch information
@kfcampbell
kfcampbell committed Jun 6, 2023
commit 9a3587f7e65d73051f78472e0b7a5311c3cc64c9
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"version": "0.0.0-development",
"description": "GitHub API token authentication for browsers and Node.js",
"scripts": {
"build": "node scripts/build.mjs && tsc -p tsconfig.json --verbatimModuleSyntax",
"build": "node scripts/build.mjs && tsc -p tsconfig.json",
"test": "jest --coverage",
"pretest": "npm run -s lint",
"lint": "prettier --check '{src,test}/**/*.{ts,md}' '*.md' package.json",
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
"declaration": true,
"outDir": "pkg/dist-types",
"emitDeclarationOnly": true,
"sourceMap": true
"sourceMap": true,
"verbatimModuleSyntax": true
},
"include": ["src/**/*"]
}