👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

There's 2 tests that are failing, I don't know why

In the test: "auth.hook(): handle 401 in first 5 seconds (#65)",

It seems that the request to GET /repos/octocat/hello-world is not resolving. Something is preventing it from resolving in 5 seconds...

@gr2m Do you have any idea why the test would fail?

It seems the timeout error is intermittent. It's passing on some of the runs

It seems the timeout error is intermittent. It's passing on some of the runs

There is only one commit that has "passed checks" because the tests did not run on that commit

I spent some time trying to figure it out. I remove the custom sinon fake timers and use Jest's own instead. But things are still not working reliably. I think this is more of a jest problem than a problem with our code or tests. I really don't like using Jest for testing because it does to much "magic". I feel it's made for front-end testing and it's great for that, but for backend, I'd either use ava or Node's built in test runner.

I still see the tests that use the jest.advanceTimersByTimeAsync() API fail like once out of 7 runs. Honestly at this point I'd tear out jest, and for the time being live with re-running CI when the tests fail

I guess the CI doesn't like it 🤷🏼 shall we just skip the two tests that cause trouble to unblock v7 and get back to it later?

Fine with me

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀