Skip to content

Update Cache#get to allow promise return type#557

Merged
wolfy1339 merged 1 commit intooctokit:mainfrom
Mause:patch-1
Dec 18, 2023
Merged

Update Cache#get to allow promise return type#557
wolfy1339 merged 1 commit intooctokit:mainfrom
Mause:patch-1

Conversation

@Mause
Copy link
Copy Markdown
Contributor

@Mause Mause commented Dec 16, 2023

Resolves #556


Before the change?

  • Typecheck fails on the Cache#get

After the change?

  • Typecheck no longer fails

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339 wolfy1339 merged commit f5e57aa into octokit:main Dec 18, 2023
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[BUG]: Cache#get type doesn't allow promises

2 participants