Skip to content

[BUG]: Cache#get type doesn't allow promises #556

@Mause

Description

@Mause

What happened?

Cache#get typescript type doesn't allow for a promise return type. The underlying code awaits the method fine though

Versions

Octokit auth app: 6.0.1
Typescript: 5.3.3
NodeJS: 18.16.1

Relevant log output

Type 'Promise<string | null>' is not assignable to type 'string'.

16     get(key: string) {
       ~~~

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Status: TriageThis is being looked at and prioritizedType: BugSomething isn't working as documented, or is being fixedreleased

    Type

    No type

    Projects

    Status

    ✅ Done

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions