fix: respect baseUrl passed as part of request parameters (#641)

gr2m · web-flow · commit 8478cac30ca2 · 2024-09-03T13:11:35.000-07:00
diff --git a/src/hook.ts b/src/hook.ts
@@ -92,7 +92,7 @@ export async function hook(
     state,
     // @ts-expect-error TBD
     {},
-    request,
+    request.defaults({ baseUrl: endpoint.baseUrl }),
   );
 
   endpoint.headers.authorization = `token ${token}`;
diff --git a/test/index.test.ts b/test/index.test.ts
@@ -2416,3 +2416,55 @@ test("auth.hook() uses app auth even for requests with query strings. (#374)", a
 
   expect(mock.done()).toBe(true);
 });
+
+test("auth.hook() respects `baseUrl` passed as part of request parameters #640", async () => {
+  const mock = fetchMock
+    .sandbox()
+    .postOnce(
+      "https://not-api.github.com/app/installations/123/access_tokens",
+      {
+        token: "secret123",
+        expires_at: "1970-01-01T01:00:00.000Z",
+        permissions: {
+          metadata: "read",
+        },
+        repository_selection: "all",
+      },
+    )
+    .get(
+      "https://not-api.github.com/repos/octocat/hello-world",
+      { id: 123 },
+      {
+        headers: {
+          authorization: "token secret123",
+        },
+        repeat: 4,
+      },
+    );
+
+  const auth = createAppAuth({
+    appId: APP_ID,
+    privateKey: PRIVATE_KEY,
+    installationId: 123,
+  });
+
+  const requestWithMock = request.defaults({
+    headers: {
+      "user-agent": "test",
+    },
+    request: {
+      fetch: mock,
+    },
+  });
+  const requestWithAuth = requestWithMock.defaults({
+    request: {
+      hook: auth.hook,
+    },
+  });
+
+  const { data } = await requestWithAuth("GET /repos/octocat/hello-world", {
+    baseUrl: "https://not-api.github.com",
+  });
+
+  expect(data).toEqual({ id: 123 });
+});
