upgrade sdk to v0.1.40 and keep the deprecated function for now#1008
Merged
cpanato merged 4 commits intoocto-sts:mainfrom Aug 26, 2025
Merged
upgrade sdk to v0.1.40 and keep the deprecated function for now#1008cpanato merged 4 commits intoocto-sts:mainfrom
cpanato merged 4 commits intoocto-sts:mainfrom
Conversation
cmdpdx
previously approved these changes
Aug 19, 2025
Comment on lines
77
to
86
| scopes := request.GetScopes() | ||
| var requestScope string | ||
| if len(scopes) == 0 { | ||
| // TODO: remove this once we upgrade the action and we can make sure we are in sync with the new way | ||
| requestScope = request.GetScope() //nolint: staticcheck | ||
| } else { | ||
| requestScope = scopes[0] | ||
| } |
Collaborator
There was a problem hiding this comment.
This looks correct now, the previous bump incorrectly was setting requestScope = "" if request.Scopes was empty, but as of [email protected] request.Scope should be populated (if any scopes were passed)
mattmoor
reviewed
Aug 20, 2025
mattmoor
reviewed
Aug 22, 2025
mattmoor
approved these changes
Aug 22, 2025
cpanato
added a commit
to octo-sts/action
that referenced
this pull request
Aug 26, 2025
related to octo-sts/app#1008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
change in the action: octo-sts/action#34