Don't try to parse response as JSON if it is an error.#37
Merged
wlynch merged 1 commit intoocto-sts:mainfrom Sep 26, 2025
Merged
Don't try to parse response as JSON if it is an error.#37wlynch merged 1 commit intoocto-sts:mainfrom
wlynch merged 1 commit intoocto-sts:mainfrom
Conversation
IdlePhysicist
approved these changes
Sep 26, 2025
If we get an error, this will often be a plain text string, and gets obfuscated by the attempted json parsing. Return it as-is so we can read it in full. Also remove unused call that isn't being used.
wlynch
force-pushed
the
noparse-error
branch
from
94467af to
552d9f9
Compare
tcnghia
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we get an error, this will often be a plain text string, and gets obfuscated by the attempted json parsing. Return it as-is so we can read it in full.