Repository navigation
fix(react-port): use pinned Jest test discovery - #2659
Merged
domgan-oai merged 2 commits intoNov 14, 2026
Merged
domgan-oai merged 2 commits into
domgan-oai merged 2 commits into
Conversation
…act-port-pinned-jest-discovery
domgan-oai
marked this pull request as ready for review
November 14, 2026 03:43
Contributor
Benchmark report🟢 No byte growth, no added work, and no timing changes beyond ±3%. Compares js-framework: 1k/10k row operationsAll 20 timed operations (20 without a verdict)
All 64 work counters are unchanged. Application bundle size (bytes)No changes across 111 measured values. Public-import reachability bundles (bytes)No changes across 141 measured values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use a verified list from Jest 29.7.0 for conventional test discovery at the immutable Framer Motion 12.42.2 pin. Keep explicit test selectors, inline sources, and compile-only tests in the inventory.
Closes #2658. Both upstream Jest configs select named tests under
src. Treating every__tests__module as a test makes the port preflight require a registration in a support helper.Validation
pnpm format:checkpnpm typecheckpnpm testpnpm sync, andgit diff --check.--listTestsreturned 94 client and 3 SSR paths. The independent preflight inventory matched all 97 and extracted 822 static registrations, including two type-test files.Risk / follow-ups
The pinned list replaces Jest's convention fallback for this package and commit. Explicit selectors remain additive. The CLI still reports pending intake until the graph's dependencies are classified. Static inventory establishes selection and registrations.
Provenance
agent-authored)Codex task · host
com-79386Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Note
Low Risk
Tooling-only changes to test inventory selection for pinned packages; behavior is gated on profiles and covered by new regression tests.
Overview
React port preflight now supports pinned Jest test discovery for immutable packages: when a versioned inventory profile includes
jestDiscovery,immutableTestInventoryvalidates config witnesses (pinned git blobs) and requires every listed test path to exist in source with countable registrations, replacing the default Jest__tests__convention for that pin.Explicit selectors, inline Vitest sources, type-test paths, and optional helper expansions still apply additively. Profile loading tolerates missing
helpers, and mismatch errors refer to test inventory profiles. A new framer-motion 12.42.2 profile records 97 Jest--listTestspaths; tests cover inventory shape and failure modes (missing witness, missing listed test, non-test content in a listed file, helpers excluded from default discovery).Reviewed by Cursor Bugbot for commit 6394e1f. Bugbot is set up for automated code reviews on this repo. Configure here.