Restore ability to specify FreeType font "named instance index"#8775
Closed
Valakor wants to merge 2 commits intoocornut:masterfrom
Closed
Restore ability to specify FreeType font "named instance index"#8775Valakor wants to merge 2 commits intoocornut:masterfrom
Valakor wants to merge 2 commits intoocornut:masterfrom
Conversation
When used with FreeType this value is passed as `face_index` which is interpreted as two 16-bit values: the lower 16 bits are the "face index" and the upper 16 are the "named instance index" for the selected face. Specifying the instance index allows for things like predefined font weights (Bold, SemiBold, Light, etc.) in many fonts.
The function `FT_New_Memory_Face` takes `FT_Long`s as arguments, which are typedefs of `signed long`. Avoid the round-trip signed->unsigned->signed cast by just casting to the destination type directly.
ocornut
pushed a commit
that referenced
this pull request
Jul 5, 2025
When used with FreeType this value is passed as `face_index` which needs to be 32-bits. # Conflicts: # docs/CHANGELOG.txt
Owner
|
Thanks for your PR. I have merged this as 0448428 with slight adjustment (the value was a specific area of the struct layout and changing from s8 to s32 increased structure size from 144 to 152 bytes. I shuffled things around to keep the struct 144 bytes with default settings). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The member
ImFontConfig::FontNois used as the argumentface_indexwhen FreeType is enabled which is a 32-bit value where the upper and lower 16 bits have different uses. One of the recent font rendering changes for 1.92 seems to have changed this member frominttoImS8which prevents specifying the full 32 bits. The upper 16 bits allow for specifying the "named instance index" / named font variation in certain fonts, like predefined font weights (Bold, SemiBold, Light, etc.).For completeness I've also fixed the call to
FT_New_Memory_Faceto use the correct casts toFT_Longwhich is a typedef ofsigned longrather thanuint32_tto avoid a signed -> unsigned -> signed roundtrip.From the FreeType doc comments: