Replace usages of ImGuiKey_KeyPadEnter with ImGuiKey_KeypadEnter.#7143
Merged
ocornut merged 1 commit intoocornut:masterfrom Dec 18, 2023
kevincoghlan:fix-regression-from-5606
Merged
Replace usages of ImGuiKey_KeyPadEnter with ImGuiKey_KeypadEnter.#7143ocornut merged 1 commit intoocornut:masterfrom kevincoghlan:fix-regression-from-5606
ocornut merged 1 commit intoocornut:masterfrom
kevincoghlan:fix-regression-from-5606
Conversation
(Two usages of ImGuiKey_KeyPadEnter were recently added to imgui.cpp (#5606), but this is an older name for the relevant enum & will not compile if IMGUI_DISABLE_OBSOLETE_FUNCTIONS is turned on.)
Owner
|
Oops thank you. Those keep biting me due to completion. I May obsolete this sooner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two usages of
ImGuiKey_KeyPadEnterwere recently added to imgui.cpp (#5606), but this is an older name for the relevant enum & will not compile ifIMGUI_DISABLE_OBSOLETE_FUNCTIONSis turned on.This PR simply switches those usages to the newer name (
ImGuiKey_KeypadEnter), which will compile regardless of theIMGUI_DISABLE_OBSOLETE_FUNCTIONSsetting.