Backends: add glBindSampler for GL ES 3.0#6375
Closed
jsm174 wants to merge 1 commit intoocornut:masterfrom
Closed
Conversation
ocornut
added a commit
that referenced
this pull request
May 9, 2023
ocornut
pushed a commit
that referenced
this pull request
May 9, 2023
Amended given addition of GlProfileIsES3 in dd9db5e
Owner
|
Hello James,
You are right. I was not confident to set GlVersion to 330 in ES3 given this is used for many things, but I have now added runtime flags in dd9db5e and reworked your commit as 39f7248 using those flags. |
Contributor
Author
|
Awesome. Thanks for getting this in!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visual Pinball uses ImGui to display it's Live UI.
While working on the cross platform port, we were getting a random flicker anytime the Live UI was visible on Android, iOS, and tvOS. The versions all use GL ES 3.0.
After using RenderDoc, we noticed the sampler was different between both frames.
glBindSampleris supported on GL ES 3.0+.I've updated the code to enable
IMGUI_IMPL_OPENGL_MAY_HAVE_BIND_SAMPLERwhen GL ES 3, and then handle it whenIMGUI_IMPL_OPENGL_ES3This PR can be reworked accordingly as I wasn't sure how to check for ES in
bd->GlVersion