Tables: do not show empty tooltip when user submits TableHeader with …#6342
Closed
lukaasm wants to merge 1 commit intoocornut:masterfrom
lukaasm:tables/empty_header_tooltip
Closed
Tables: do not show empty tooltip when user submits TableHeader with …#6342lukaasm wants to merge 1 commit intoocornut:masterfrom lukaasm:tables/empty_header_tooltip
lukaasm wants to merge 1 commit intoocornut:masterfrom
lukaasm:tables/empty_header_tooltip
Conversation
…no label to display
Owner
|
Merged as e49d31a, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…no label to display
When building custom table header with sorting enabled:
I am calling
ImGui::TableHeader( "##column" );so I still retain native table header highlight and context menu support.But submitting label with no text to display, causes empty tooltip to be shown when the cell is hovered:

The issue is caused by the calculation of ellipsis_max:
which goes below label_pos.x:
and makes condition of:
wrongly positive.
This PR forces an assumption that the ellipsis position can not go below the min x position of the label.