Fix adding events to an inactive context#6256
Closed
cfillion wants to merge 3 commits intoocornut:dockingfrom
Closed
Fix adding events to an inactive context#6256cfillion wants to merge 3 commits intoocornut:dockingfrom
cfillion wants to merge 3 commits intoocornut:dockingfrom
Conversation
cfillion
force-pushed
the
fix-add-event-multictx
branch
from
ba2cb4b to
01cfe56
Compare
Owner
|
Thanks! |
Owner
This is indeed problematic as is, as depending on GImGui storage type it may break the expectation that ImGuiIO AddEventXXX calls may be thread-safe. The "right" solution would be adding a ctx pointer to |
ocornut
added a commit
that referenced
this pull request
Mar 21, 2023
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.89.4's release notes mention that events can now be added to any context:
However this is broken:
FindLatestInputEventcalled by most AddXXXEvent functions uses the current global contextAddKeyEventcallsImGui::GetKeyDatawhich also uses the current contextAddMouseViewportEventfrom the docking branch still has the old "Can only add events to current context" assertionThere's probably a better solution for
GetKeyDatathan temporarily changing the current context. This PR is based on the docking branch because of the lastAddMouseViewportEventfix. The first two commits cleanly apply to the current master branch.