Moving DockingSplitterSize to ImGuiStyle#4721
Closed
wobbier wants to merge 1 commit intoocornut:dockingfrom
Closed
Moving DockingSplitterSize to ImGuiStyle#4721wobbier wants to merge 1 commit intoocornut:dockingfrom
wobbier wants to merge 1 commit intoocornut:dockingfrom
Conversation
Author
|
Ah, Just found this PR: #3481 |
ocornut
changed the title
Owner
Author
|
I personally think this should be a separate option (a single float), and we add a second ImVec2 for the "docking space padding". Unless you're talking about docked panels having their own inner / outer spacing different from padding? |
ocornut
pushed a commit
that referenced
this pull request
Jul 11, 2023
ocornut
added a commit
that referenced
this pull request
Jul 11, 2023
Owner
|
Closed this see comment #3481 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I got into styling ImGui quite a bit, and needed to modify the thickness of the docking splitter.
I moved the existing global variable into the style, I've updated the various places it was used, and added it to the style tab in imgui_demo.cpp
My only notes/questions are:
const float dock_spacing = 0.0f;// g.Style.ItemInnerSpacing.x; // FIXME: Relation to Style.DockingSplitterSize?